-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix watcher not fully paginating on Init #1525
Conversation
cannot believe i missed this :( fixes #1524 Signed-off-by: clux <sszynrae@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1525 +/- ##
=======================================
+ Coverage 75.1% 75.1% +0.1%
=======================================
Files 78 78
Lines 6980 6991 +11
=======================================
+ Hits 5238 5249 +11
Misses 1742 1742
|
Signed-off-by: clux <sszynrae@gmail.com>
Annoyingly this also "appears to undo" parts of the memory benefits that i benchmarked for 0.92.. will have to update the post later, but so far, even the starting memory (5m in after init) is doing better than 0.91, but it is more situational
given that these controllers have also had about a week to run 0.92 it's also clear that these leak much more memory than before, and in context of the bug, this also kind of makes sense; the reflectors were not full at the beginning - and the gains i saw by measuring at the start would not last anyway. maybe there are some more optimizations to do, but it's more important to not have a broken release out here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
:)
* Fix watcher not fully paginating on Init cannot believe i missed this :( fixes #1524 Signed-off-by: clux <sszynrae@gmail.com> * upgrade mock test (these fail on master) Signed-off-by: clux <sszynrae@gmail.com> --------- Signed-off-by: clux <sszynrae@gmail.com>
released in https://github.com/kube-rs/kube/releases/tag/0.92.1 from 0.92.x branch (cherry-picked in this commit). |
main
)will cherry-pick to a 0.92.1 branch and release from there
cannot believe i missed this :(