Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo deny mutliple-fields ban #711

Merged
merged 4 commits into from
Nov 15, 2021
Merged

cargo deny mutliple-fields ban #711

merged 4 commits into from
Nov 15, 2021

Conversation

clux
Copy link
Member

@clux clux commented Nov 15, 2021

using https://embarkstudios.github.io/cargo-deny/checks/bans/cfg.html#the-multiple-versions-field-optional
to try to prevent issues like #709 in the future

i had issues originally, but deleted my local Cargo.lock and on a rebuild all the duplicates had gone away.

will add and remove a duplicate dependency here to ensure that this setup works.

(there are ways to temporarily whitelist from the duplicate ban list, so this shouldn't be a big inconvenience)

Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
@clux
Copy link
Member Author

clux commented Nov 15, 2021

Test failed as it does locally:

error[B004]: found 2 duplicate entries for crate 'tungstenite'
    ┌─ /github/workspace/Cargo.lock:220:1
    │  
220 │ ╭ tungstenite 0.13.0 registry+https://github.com/rust-lang/crates.io-index
221 │ │ tungstenite 0.14.0 registry+https://github.com/rust-lang/crates.io-index
    │ ╰────────────────────────────────────────────────────────────────────────^ lock entries

@clux clux changed the title cargo deny mutliple-fields warning cargo deny mutliple-fields ban Nov 15, 2021
Signed-off-by: clux <sszynrae@gmail.com>
@clux clux marked this pull request as ready for review November 15, 2021 21:53
@clux clux requested a review from kazk November 15, 2021 21:53
@kazk
Copy link
Member

kazk commented Nov 15, 2021

There's a warning

warning[S006]: allowed 'github.com' organization  was not encountered
   ┌─ /github/workspace/deny.toml:64:11
   │
64 │ github = ["kube-rs"]
   │           ^^^^^^^^^ no crate source fell under this organization

Is this necessary for something?
https://github.com/kube-rs/kube-rs/blob/519cc7b6332b059cf0c487d81f6d32e5579272a7/deny.toml#L63-L64

@clux
Copy link
Member Author

clux commented Nov 15, 2021

Is this necessary for something?

Technically no. i think Lars put it there as a convenience to allow things in a big org with private repos, but we don't have that stuff. I'll remove it.

Signed-off-by: clux <sszynrae@gmail.com>
@clux
Copy link
Member Author

clux commented Nov 15, 2021

Warning gone. Merging.

@clux clux merged commit 398cb14 into master Nov 15, 2021
@clux clux deleted the cargo-deny-multiple branch November 15, 2021 22:20
@kazk kazk mentioned this pull request Nov 15, 2021
3 tasks
@clux clux mentioned this pull request Nov 21, 2021
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants