Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load namespace when run in a cluster #74

Merged
merged 3 commits into from
Oct 6, 2019
Merged

Load namespace when run in a cluster #74

merged 3 commits into from
Oct 6, 2019

Conversation

dylanhart
Copy link
Contributor

Fixes #69

@dylanhart
Copy link
Contributor Author

CI failure looks to be an existing config issue?

# No configuration was found in your project. Please refer to https://circleci.com/docs/2.0/ to get started with your configuration.
# 
# -------
# Warning: This configuration was auto-generated to show you the message above.
# Don't rerun this job. Rerunning will have no effect.
false

@clux
Copy link
Member

clux commented Oct 6, 2019

Hey, thanks a lot for doing this. Not sure what the CI failure was, but updated your branch and it now seems to fail legitimately.

@dylanhart
Copy link
Contributor Author

Whoops! forgot to push a fixup commit earlier.

@dylanhart
Copy link
Contributor Author

oh shoot.. I killed your changes...

@clux
Copy link
Member

clux commented Oct 6, 2019

Np. Was just a branch merge :-)

clux
clux approved these changes Oct 6, 2019
View reviewed changes
Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks safe to me! Will double check some things around it during the week and release (since the in-cluster config isn't really tested well), but spec looks pretty clear on this.

@clux clux merged commit 5fa24aa into kube-rs:master Oct 6, 2019
alecmocatta added a commit to constellation-rs/constellation that referenced this pull request Oct 15, 2019
@alecmocatta
let kube get in-cluster default namespace given kube-rs/kube#74
0afcd15
alecmocatta added a commit to constellation-rs/constellation that referenced this pull request Oct 15, 2019
@alecmocatta
let kube get in-cluster default namespace given kube-rs/kube#74
6f8d692
alecmocatta added a commit to constellation-rs/constellation that referenced this pull request Oct 15, 2019
@alecmocatta
let kube get in-cluster default namespace given kube-rs/kube#74
ef2c02e
@alecmocatta alecmocatta mentioned this pull request Oct 15, 2019
Merged
alecmocatta added a commit to constellation-rs/constellation that referenced this pull request Oct 24, 2019
@alecmocatta
let kube get in-cluster default namespace given kube-rs/kube#74
dfc9ebd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clux clux clux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Retrieve the default namespace when running in cluster
2 participants
@dylanhart @clux