Remove deprecated legacy crd v1beta1 #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no major cloud providers supports it anymore Signed-off-by: clux <sszynrae@gmail.com>
|
cc @lfrancke , do you guys need this still? |
3 tasks
This comment was marked as spam.
This comment was marked as spam.
|
Thank you for thinking of us. I'll check and will get back to you shortly. |
|
We (@stackabletech) haven't supported v1b1 since at least back when I joined, and I don't really see that changing any time soon. |
kazk
approved these changes
May 3, 2022
clux
added a commit
that referenced
this pull request
May 24, 2022
This relies on CustomResourceDefinition at the removed v1beta1 which we previously removed also support for in #890. Signed-off-by: clux <sszynrae@gmail.com>
clux
added a commit
that referenced
this pull request
May 24, 2022
* Remove apiextensions flag from kube-derive This relies on CustomResourceDefinition at the removed v1beta1 which we previously removed also support for in #890. Signed-off-by: clux <sszynrae@gmail.com> * remove stray uses in tests Signed-off-by: clux <sszynrae@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no major cloud providers needs it anymore (removed in 1.22 but you need to be on Kubernetes < 1.16 to not have v1 - see this)
might create a thing for MK8SV as 1.16 as well if this is approved.
(1.16 is lower than what we would support with the future version plan)
EDIT: The debatable point is whether we should keep it around until the version of kubernetes that removed it becomes unavailable, in which case we might wait for another while. I think it's fine, it's in line with the future versioning plan. It's not only deprecated, it's fully removed upstream, we should do the same.