Fix makefile default target #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: runsisi <runsisi@hust.edu.cn>
At some point, I really need to learn about makefiles. I don't suppose you could be a little clearer about what this change does? |
|
i think found the issue when building w/o target specified: ❯ make
go mod tidy
go: downloading k8s.io/api v0.26.2
...
go: downloading github.com/google/pprof v0.0.0-20210407192527-94a9f03dee38
test -z ""
test -z || echo "[WARN] Fix formatting issues with 'make fmt'"
golangci-lint run
make: golangci-lint: No such file or directory
make: *** [Makefile:96: check] Error 127the default target should be the value of Footnotes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.