fix(application): add isReady check for all nodes in application #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abirdcfly
force-pushed
the
controller
branch
5 times, most recently
from
d4c14fc
to
20ef32e
Compare
Abirdcfly
force-pushed
the
controller
branch
8 times, most recently
from
e5052aa
to
7fc81be
Compare
Abirdcfly
changed the title
Abirdcfly
force-pushed
the
controller
branch
from
7fc81be
to
98f101e
Compare
This commit adds `Ready` methods to all nodes in the application. These methods provide a consistent way to check if a node is ready and to get any error messages that may have occurred during node initialization or execution. The following changes were made to implement this feature: - Added `Ready` methods to the `Node` interface. - Implemented `Ready` methods for all existing node types. - Updated the application controller to use the `Ready` methods to check if nodes are ready and to handle any errors that may occur. Signed-off-by: Abirdcfly <fp544037857@gmail.com>
Abirdcfly
force-pushed
the
controller
branch
from
98f101e
to
7156ee8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it
This commit adds
Readymethods to all nodes in the application.These methods provide a consistent way to check if a node is ready and to get any error messages that may have occurred during node initialization or execution.
The following changes were made to implement this feature:
Readymethods to theNodeinterface.Readymethods for all existing node types.Readymethods to check if nodes are ready and to handle any errors that may occur.Which issue(s) this PR fixes
Fixes #
Special notes for your reviewer
based on #696, need merge that first.