-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support toleration config #1731
Conversation
f95f9ca
to
b2c6863
Compare
@tico88612 please rebase to the main and squash the commits. |
@rksharma95 rebased. |
the changes looks good to me 👍 , let me know if you have any specific question i will try best to answer that. |
Feat: KubeArmor chart values add kubearmor-controller toleration Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com> Feat: KubeArmor chart values add kubearmor-relay toleration Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com> Typo: KubeArmor chart values comment wrong fix Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com> Feat: KubeArmorOperator chart values add deployment toleration Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com> Chore: update KubeArmorOperator controller-gen from v0.4.1 to v0.14.0 Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com> Feat: KubeArmorConfigSpec Relay & Controller add Toleration Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com> Command: controller-gen update KubeArmorConfig CRD Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com> Feat: add KubeArmorConfig toleration default value Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com> Feat: implement tolerations in operator Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com>
36d338c
to
652f92f
Compare
|
@tico88612 I tried to test the PR, seems like there are some issues, operator is not able to handle the toleration config. kubearmorconfig
Relay Pod:
Node:
|
What are some of the things I've missed about the modifications? |
I don't see anything missing, there might be something not working as expected. |
@tico88612 any update here? let me know if you need any assistance. |
Hi @rksharma95 |
@tico88612 is there any update? Are you still working on it? |
@rksharma95 Sorry for the slow reply, but since I haven't had time to work on this lately, I've decided to release the work to other potential contributors! |
Purpose of PR?:
Fixes #1720
Does this PR introduce a breaking change?
Probably not.
If the changes in this PR are manually verified, list down the scenarios covered::
Additional information for reviewer? :
I'm a newbie developer operator CRD. I need suggestions about coding style or any important that I missed.
BTW, I haven't written a test yet, need advice.
Checklist:
<type>(<scope>): <subject>