-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deploy/core: kubearmor for GKE latest COS images #648
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nam-jaehyun
reviewed
Mar 14, 2022
nyrahul
force-pushed
the
main
branch
2 times, most recently
from
March 14, 2022 11:16
342149a
to
dab5cee
Compare
nam-jaehyun
approved these changes
Mar 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to merge it!
daemon1024
reviewed
Mar 14, 2022
daemon1024
approved these changes
Mar 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* latest GKE COS images do not have path for /usr/src. * deploygen updated to create kubearmor.yamls accordingly Detailed description: GKE supports multiple images types, viz COS and non-COS(Ubuntu, Debian etc). In case of non-COS images, the `/usr/src` contains the kernel headers. In case of COS, kubearmor internally downloads the kernel headers but still it used to mount `/usr/src` since we used a single yaml for COS and non-COS images. In the latest releases of COS images (for e.g., 1.22.6-gke-1000), the `/usr/src` folder is no longer present. The current changes now mounts /usr to `/media/root/usr` folder for GKE (only). The kubearmor code internally sets `BCC_KERNEL_SOURCE` to `/media/root/usr/src/linux-headers-KERNELVER`. Fixes kubearmor#579 Signed-off-by: Rahul Jadhav <nyrahul@gmail.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description:
GKE supports multiple images types, viz COS and non-COS(Ubuntu, Debian
etc). In case of non-COS images, the
/usr/src
contains the kernelheaders. In case of COS, kubearmor internally downloads the kernel
headers but still it used to mount
/usr/src
since we used a single yamlfor COS and non-COS images. In the latest releases of COS images
(for e.g., 1.22.6-gke-1000), the
/usr/src
folder is no longerpresent. The current changes now mounts /usr to /opt/hostusr folder for
GKE (only). The kubearmor code internally sets
BCC_KERNEL_SOURCE
to/media/root/usr/src/linux-headers-KERNELVER
.Fixes #579
Signed-off-by: Rahul Jadhav nyrahul@gmail.com