Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove backed-up host policy on policy removal #658

Merged
merged 3 commits into from
Mar 21, 2022
Merged

Remove backed-up host policy on policy removal #658

merged 3 commits into from
Mar 21, 2022

Conversation

seswarrajan
Copy link
Contributor

Signed-off-by: Eswar Rajan Subramanian eswar@accuknox.com

Signed-off-by: Eswar Rajan Subramanian <eswar@accuknox.com>
Copy link
Contributor

@nyrahul nyrahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good to me. Couple of trivial comments.

KubeArmor/core/kubeUpdate.go Outdated Show resolved Hide resolved
KubeArmor/core/kubeUpdate.go Outdated Show resolved Hide resolved
Co-authored-by: Rahul Jadhav <nyrahul@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2022

Codecov Report

Merging #658 (a332498) into main (76baf1c) will decrease coverage by 0.77%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #658      +/-   ##
==========================================
- Coverage   43.34%   42.56%   -0.78%     
==========================================
  Files          23       23              
  Lines        8539     8553      +14     
==========================================
- Hits         3701     3641      -60     
- Misses       4385     4466      +81     
+ Partials      453      446       -7     
Impacted Files Coverage Δ
KubeArmor/core/kubeUpdate.go 44.27% <0.00%> (-0.52%) ⬇️
KubeArmor/monitor/systemMonitor.go 38.23% <0.00%> (-10.85%) ⬇️
KubeArmor/monitor/processTree.go 90.50% <0.00%> (-0.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76baf1c...a332498. Read the comment docs.

Signed-off-by: Eswar Rajan Subramanian <eswar@accuknox.com>
Copy link
Contributor

@nyrahul nyrahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please squash the commits.

@seswarrajan seswarrajan merged commit 5c61070 into kubearmor:main Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants