Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated localPort value to not bind with with any port to be used by … #247

Merged
merged 2 commits into from
Jan 26, 2023

Conversation

TheRealSibasishBehera
Copy link
Contributor

Signed-off-by: sibashi fangedhamster3114@gmail.com

Fixes KubeArmor-#1051

  • previously karmor used to bind to port 32767 , if karmor log was used before all KubeArmor were running during karmor install . This caused kubearmor pod failing to run , as it requires to use 32767

  • Now karmor would not bind to 32767 , instead keep looking for other local ports > 32767

…KubeArmor pods

Signed-off-by: sibashi <fangedhamster3114@gmail.com>
@nyrahul nyrahul requested a review from Ankurk99 January 24, 2023 08:08
Copy link
Member

@Ankurk99 Ankurk99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a nit suggested inline

utils/portforward.go Outdated Show resolved Hide resolved
Signed-off-by: sibashi <fangedhamster3114@gmail.com>
@Ankurk99 Ankurk99 merged commit f12ff0b into kubearmor:main Jan 26, 2023
@Ankurk99
Copy link
Member

Thanks for the PR @TheRealSibasishBehera 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KubeArmor crashing if port 32767 already in use
2 participants