fix golangci-lint issues reported #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
avrodrigues5
changed the title
chipzoller
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Fixes some golangci-lint complains
Does this PR rely on any other PRs?
No
How does this PR impact users?
None as minor changes on error checking while binding pflag to viper, using io.ReadAll instead of ioutil.ReadAll[DEPRECATED]
Links to Issues or tickets this PR addresses or fixes
Closes #28
What risks are associated with merging this PR? What is required to fully test this PR?
None
How was this PR tested?
Tested it in audit mode, most significant change was the io/util ReadAll function to io.ReadAll and worked fine! Then Ran golangci-lint locally.