Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix broken links and add some info about sig-robotics #134

Merged
merged 3 commits into from
Jul 29, 2023
Merged

fix broken links and add some info about sig-robotics #134

merged 3 commits into from
Jul 29, 2023

Conversation

JoeyHwong-gk
Copy link
Contributor

@JoeyHwong-gk JoeyHwong-gk commented Jan 18, 2023 •
edited
Loading

fix #136

Signed-off-by: JoeyHwong-gk joeyhwong@gknow.cn

@kubeedge-bot
Copy link
Collaborator

Welcome @JoeyHwong-gk! It looks like this is your first PR to kubeedge/community 🎉

@kubeedge-bot kubeedge-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 18, 2023
@JoeyHwong-gk
Copy link
Contributor Author

CC: @fisherxu @kevin-wangzefeng

fisherxu
fisherxu reviewed Jan 18, 2023
View reviewed changes
sig-robotics/README.md Outdated Show resolved Hide resolved
@kubeedge-bot kubeedge-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 18, 2023
@kubeedge-bot kubeedge-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 18, 2023
@JoeyHwong-gk JoeyHwong-gk reopened this Jan 18, 2023
@kubeedge-bot kubeedge-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 18, 2023
fisherxu
fisherxu reviewed Jan 29, 2023
View reviewed changes
sig-robotics/README.md Outdated Show resolved Hide resolved
fujitatomoya
fujitatomoya reviewed Feb 14, 2023
View reviewed changes
Copy link
Contributor

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoeyHwong-gk thanks for addressing this, looks good to me.

sig-robotics/README.md Outdated
- Zhengguang Ou (@ugvddm), Huawei
- JoeyHwong (@JoeyHwong-gk)

> The co-chair is still open for recruitment. If any individual or organization is willing to participate in our community work, please send an email to [kubeedge](kubeedge@googlegroups.com).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure how much I can commit this, but would like to join if I am eligible to this participation.

Copy link
Contributor Author

@JoeyHwong-gk JoeyHwong-gk Feb 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for reaching out! We're absolutely thrilled that you're interested in joining our community, and we're excited to see the unique perspectives and contributions you'll bring to the table.
We think your background is a perfect fit for our community, and we can't wait to have you on board.

Regarding the co-chair election, we'll reach out to the KubeEdge TSC (@kevin-wangzefeng @fisherxu) to create a document outlining the guidelines and requirements for the role, and we'll make sure to publish it in the community to keep everyone in the loop.

Thanks again for your enthusiasm and interest in KubeEdge - we're lucky to have you!

@kubeedge-bot kubeedge-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 7, 2023
fujitatomoya
fujitatomoya suggested changes Apr 7, 2023
View reviewed changes
Copy link
Contributor

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment, could you check just in case?

sig-robotics/README.md Outdated Show resolved Hide resolved
@kevin-wangzefeng
Copy link
Member

@JoeyHwong-gk The DCO check is still failing, could you fix it?

@JoeyHwong-gk @fisherxu
fix broken links and add some info about sig-robotics
fb565ef 
Co-authored-by: Fisher Xu <xufei40@huawei.com>
Signed-off-by: JoeyHwong-gk <joeyhwong@gknow.cn>
@JoeyHwong-gk
Copy link
Contributor Author

JoeyHwong-gk commented Jul 11, 2023 •
edited
Loading

@JoeyHwong-gk The DCO check is still failing, could you fix it?

fixed. Thank you for your kind reminder, and I apologize for the oversight. /PTLA @kevin-wangzefeng

fujitatomoya
fujitatomoya reviewed Jul 11, 2023
View reviewed changes
sig-robotics/README.md Outdated

## Contact
- Slack: [#sig-robotics]()

- [#sig-Robotics slack channel](https://join.slack.com/t/kubeedge/shared_invite/enQtNjc0MTg2NTg2MTk0LWJmOTBmOGRkZWNhMTVkNGU1ZjkwNDY4MTY4YTAwNDAyMjRkMjdlMjIzYmMxODY1NGZjYzc4MWM5YmIxZjU1ZDI)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we actually have this dedicated channel named sig-Robotics? i cannot find KubeEdge slack...

JoeyHwong-gk and others added 2 commits July 29, 2023 17:48
@JoeyHwong-gk @fujitatomoya
Fix the typo
f89da8e 
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Signed-off-by: JoeyHwong-gk <joeyhwong@gknow.cn>
@JoeyHwong-gk @kevin-wangzefeng
Update sig-robotics/README.md
911e064 
Co-authored-by: Kevin Wang <kevinwzf0126@gmail.com>
Signed-off-by: JoeyHwong-gk <joeyhwong@gknow.cn>
@kevin-wangzefeng
Copy link
Member

/lgtm
/approve

Thanks!

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2023
@kevin-wangzefeng kevin-wangzefeng added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2023
@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: kevin-wangzefeng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot merged commit c4fe8f0 into kubeedge:master Jul 29, 2023
1 check passed
@JoeyHwong-gk JoeyHwong-gk mentioned this pull request Sep 18, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya requested changes

@fisherxu fisherxu fisherxu left review comments

@kevin-wangzefeng kevin-wangzefeng kevin-wangzefeng left review comments

Assignees

@kevin-wangzefeng kevin-wangzefeng

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sig-robotics community links are broken.
5 participants
@JoeyHwong-gk @kubeedge-bot @kevin-wangzefeng @fisherxu @fujitatomoya