Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed #65,#66 kubeedge-counter-demo is not working properly #87

Closed
wants to merge 0 commits into from

Conversation

tsunli
Copy link

@tsunli tsunli commented Dec 22, 2020

update kubeedge-counter-demo
fixed #65,#66 kubeedge-counter-demo is not working properly

@fisherxu
Copy link
Member

Thanks for the fixing, looks like you vendered all the kubeedge main repo? :)

@tsunli
Copy link
Author

tsunli commented Dec 22, 2020

Thanks for the fixing, looks like you vendered all the kubeedge main repo? :)

yes.simple copy main repo.

@daixiang0
Copy link
Member

Similiar as #57

@daixiang0
Copy link
Member

daixiang0 commented Jan 8, 2021

@tsunli Please try the latest example to confirm this issue exists or not, it works at my env, thanks :)

@kubeedge-bot kubeedge-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 14, 2021
@kubeedge-bot
Copy link
Collaborator

@tsunli: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tsunli tsunli closed this Jan 14, 2021
@kubeedge-bot kubeedge-bot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jan 14, 2021
@kubeedge-bot
Copy link
Collaborator

Keywords which can automatically close issues and at(@) mentions are not allowed in the title of a Pull Request.

You can edit the title by writing /retitle in a comment.

When GitHub merges a Pull Request, the title is included in the merge commit. To avoid invalid keywords in the merge commit, please edit the title of the PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KubeEdge Counter Demo is not working properly
4 participants