Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloud/pkg/cloudstream/streamserver.go: fix typo, shoud be "streamServer" #2065

Merged
merged 1 commit into from
Aug 24, 2020

Conversation

YaozhongZhang
Copy link

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind test
/kind failing-test
/kind feature

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@kubeedge-bot kubeedge-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 13, 2020
@kubeedge-bot kubeedge-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 13, 2020
@daixiang0
Copy link
Member

Please add filepath in the title, it would be more meaningful.

@YaozhongZhang YaozhongZhang changed the title fix typo cloud/pkg/cloudstream/streamserver.go: fix typo, shoud be "streamServer" Aug 17, 2020
@YaozhongZhang
Copy link
Author

Please add filepath in the title, it would be more meaningful.

ok, thx.

@fisherxu
Copy link
Member

Looks like we have a field TunnelServer in StreamServer @YaozhongZhang So do we need rename here?

@YaozhongZhang
Copy link
Author

Looks like we have a field TunnelServer in StreamServer @YaozhongZhang So do we need rename here?

klog.Infof("Prepare to start stream server ...")

@fisherxu Obviously it's StreamServer here.

@fisherxu
Copy link
Member

/lgtm
/approve

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2020
@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fisherxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2020
@kubeedge-bot kubeedge-bot merged commit e72f43c into kubeedge:master Aug 24, 2020
@YaozhongZhang YaozhongZhang deleted the fix-typo branch October 14, 2020 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants