-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix deviceProfile json bug #2143
Conversation
Welcome @jidalong! It looks like this is your first PR to kubeedge/kubeedge 🎉 |
@jidalong Thanks for the fixing! I think we shoud modify all |
I am sure it is
|
Okey, so please modify all |
|
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fisherxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Once a device is created for the edge node, deviceController may create a device configMap for this edge node. Then we can monut this configmap to mapper container。 In my knowledge, the deviceProfile.json file is an example for modbus device configmap, but the in the kubeedge code,the filed of protocol config in configmap is named protocol_config not protocolConfig. And the mapper also use the protocol_config not protocolConfig to prase the dpl json.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: