Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add router servicebus #2588

Merged
merged 7 commits into from
May 31, 2021
Merged

add router servicebus #2588

merged 7 commits into from
May 31, 2021

Conversation

WintonChan
Copy link
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:
to deliver message between rest client on cloud and server on edge
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
NONE

@kubeedge-bot kubeedge-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. labels Feb 27, 2021
@kubeedge-bot kubeedge-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 27, 2021
@WintonChan WintonChan force-pushed the feature/add-router-servicebus branch 5 times, most recently from e3873c3 to 8c5c83d Compare March 1, 2021 08:27
@kubeedge-bot kubeedge-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 1, 2021
@Elaine4CY Elaine4CY force-pushed the feature/add-router-servicebus branch from 8efc9e7 to 29bdd07 Compare March 2, 2021 08:20
@kubeedge-bot kubeedge-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 2, 2021
@Elaine4CY Elaine4CY force-pushed the feature/add-router-servicebus branch 2 times, most recently from e6ac290 to 52e61f5 Compare March 2, 2021 09:35
@kubeedge-bot kubeedge-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 2, 2021
@WintonChan WintonChan force-pushed the feature/add-router-servicebus branch from 59be380 to 436bf2e Compare March 2, 2021 12:06
@Elaine4CY Elaine4CY force-pushed the feature/add-router-servicebus branch from 28d2e5f to 6db61c4 Compare March 3, 2021 02:53
@WintonChan WintonChan changed the title WIP:add router servicebus add router servicebus Mar 3, 2021
@kubeedge-bot kubeedge-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 3, 2021
@WintonChan WintonChan changed the title add router servicebus add router servicebus model Mar 3, 2021
@WintonChan WintonChan changed the title add router servicebus model add router servicebus Mar 3, 2021
@WintonChan WintonChan closed this Mar 3, 2021
@WintonChan WintonChan reopened this Mar 3, 2021
@WintonChan WintonChan closed this Mar 3, 2021
@WintonChan WintonChan reopened this Mar 3, 2021
@WintonChan WintonChan force-pushed the feature/add-router-servicebus branch from 6db61c4 to b598222 Compare March 4, 2021 07:20
@WintonChan WintonChan force-pushed the feature/add-router-servicebus branch from 8600b66 to 8d6bd6c Compare May 6, 2021 01:48
@liufen90
Copy link
Contributor

liufen90 commented May 6, 2021

/approve

liufen90
liufen90 reviewed May 10, 2021
View reviewed changes
cloud/pkg/admissioncontroller/admit_rule.go Outdated Show resolved Hide resolved
cloud/pkg/router/provider/rest/rest.go Outdated Show resolved Hide resolved
@liufen90
Copy link
Contributor

fix #2558

@WintonChan
Copy link
Contributor Author

@fisherxu plz merge this pr

@fisherxu
Copy link
Member

@fisherxu plz merge this pr

I'll take a look.

@WintonChan
Copy link
Contributor Author

/assign @fisherxu

@WintonChan WintonChan force-pushed the feature/add-router-servicebus branch from 8d6bd6c to 3d82ad8 Compare May 24, 2021 07:31
@WintonChan
Copy link
Contributor Author

@fisherxu, Is there any problem with this pr?

@WintonChan WintonChan force-pushed the feature/add-router-servicebus branch from 3d82ad8 to b23566a Compare May 27, 2021 09:52
@WintonChan
Copy link
Contributor Author

@fisherxu conflict has been solved

@WintonChan WintonChan force-pushed the feature/add-router-servicebus branch 4 times, most recently from 2c75047 to 67f7220 Compare May 28, 2021 06:32
Elaine4CY and others added 7 commits May 31, 2021 10:09
@Elaine4CY @WintonChan
add servicebus
62bcded 
Signed-off-by: WintonChan <cw_hao@163.com>
Signed-off-by: Elaine4CY <chenyuncy2017@outlook.com>
@WintonChan
modify rest provider of router to return response
4715b79 
Signed-off-by: WintonChan <cw_hao@163.com>
@WintonChan
add admission of servicebus in rule and rule endpoint
b65d092 
Signed-off-by: WintonChan <cw_hao@163.com>
@Elaine4CY @WintonChan
add e2e test: Rest to ServiceBus
fec89d4 
Signed-off-by: Elaine4CY <chenyuncy2017@outlook.com>
@WintonChan
fix CI problem
746887d 
Signed-off-by: WintonChan <cw_hao@163.com>
@Elaine4CY @WintonChan
enable serviceBus
ee4c104 
Signed-off-by: Elaine4CY <chenyuncy2017@outlook.com>
@WintonChan
fix issues
111783b 
Signed-off-by: WintonChan <cw_hao@163.com>
@WintonChan WintonChan force-pushed the feature/add-router-servicebus branch from 67f7220 to 111783b Compare May 31, 2021 02:10
fisherxu
fisherxu reviewed May 31, 2021
View reviewed changes
Copy link
Member

@fisherxu fisherxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2021
@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fisherxu, liufen90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2021
@kubeedge-bot kubeedge-bot merged commit 4f1b3a9 into kubeedge:master May 31, 2021
@WintonChan WintonChan mentioned this pull request Jun 3, 2021
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fisherxu fisherxu fisherxu left review comments

@liufen90 liufen90 liufen90 left review comments

@kadisi kadisi Awaiting requested review from kadisi

Assignees

@fisherxu fisherxu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@WintonChan @liufen90 @fisherxu @kubeedge-bot @Elaine4CY