Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add physical cluster templates to Google Cloud Project #769

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

mrsimonemms
Copy link
Contributor

@mrsimonemms mrsimonemms commented Jul 3, 2024

Description

This adds the option to create a physical GKE cluster in Kubefirst

Before this is merged, I have a couple of questions about how this should be done best.

  • The console has "cloud zone" as a required field, but I've done this across all zones which arguably better for prod-grade clusters. Should we change the console to cater for per-zone and multi-zone?
  • The console assumes a static number of nodes - should we allow autoscaling with min/max nodes and static number of nodes?

Related Issue(s)

Fixes #765

How to test

I have a dev version running. I can sync with reviewer(s) to use this

  1. Create a dev deployment of Kubefirst to Google
  2. Create a physical cluster in the dashboard
  3. Profit

NB. Physical clusters in GCP are a paid-feature. There is a Posthog feature flag to allow this for a development version only.

@mrsimonemms mrsimonemms marked this pull request as ready for review July 3, 2024 12:30
@fharper fharper added the enhancement New feature or request label Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

complete physical cluster management in google cloud
3 participants