Skip to content
This repository has been archived by the owner on Sep 12, 2023. It is now read-only.

Feat(event): record the tfjob event from the abnormal pod status #101

Merged
merged 2 commits into from
Oct 7, 2020

Conversation

whalecold
Copy link
Contributor

@kubeflow-bot
Copy link

This change is Reviewable

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for your contribution! 🎉 👍

pkg/controller.v1/common/job.go Outdated Show resolved Hide resolved
@google-cla
Copy link

google-cla bot commented Aug 28, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@gaocegege
Copy link
Member

Please make sure that the commits are all from your account. Or the CLA will not pass.

@whalecold
Copy link
Contributor Author

Please make sure that the commits are all from your account. Or the CLA will not pass.

Done, PTAL

Copy link
Member

@Jeffwan Jeffwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is straightforward. Thanks for the change

@Jeffwan
Copy link
Member

Jeffwan commented Oct 7, 2020

Seems @gaocegege already approve the change, LGTM as well

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jeffwan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 31a6ec1 into kubeflow:master Oct 7, 2020
@whalecold whalecold deleted the recorder branch October 12, 2020 06:09
georgkaleido pushed a commit to georgkaleido/common that referenced this pull request Jun 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants