Make ports more flexiable for customizations

[xieydd]

Signed-off-by: xieydd chrisydxie@tencent.com
Try to resolve issue #122 .
This has been tested with tf-operator.

# tf-job
Worker:
  template:
    spec:
      ports:
      - name: test
        containerPort: 80

# worker svc
spec:
  clusterIP: None
  ports:
  - name: test
    port: 80
    protocol: TCP
    targetPort: 80
  - name: tfjob-port
    port: 2222
    protocol: TCP
    targetPort: 2222
  selector:
    group-name: kubeflow.org
    job-name: dist-mnist-for-e2e-test
    replica-index: "0"
    replica-type: ps
  sessionAffinity: None
  type: ClusterIP

[gaocegege]

There is no need to make the map a pointer, I think.

[gaocegege]

Suggested change

	func (jc *JobController) GetPortsFromJob(spec *apiv1.ReplicaSpec) (*map[string]int32, error) {
	func (jc *JobController) GetPortsFromJob(spec *apiv1.ReplicaSpec) (map[string]int32, error) {

[xieydd]

Yep, you are right.

[Jeffwan]

Looks straight forward. @gaocegege please have another look

/approve

[terrytangyuan]

LGTM. Thanks!

[google-oss-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jeffwan, terrytangyuan, xieydd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Jeffwan,terrytangyuan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gaocegege]

The code LGTM, should we add some test cases?

[Jeffwan]

The code LGTM, should we add some test cases?

I think test_job can be updated for testing purpose. @xieydd Can you help take a look?

[xieydd]

Add test case make sense, i will add it.

[gaocegege]

/lgtm