Skip to content
This repository has been archived by the owner on Sep 12, 2023. It is now read-only.

Add fully-qualified labels #150

Merged
merged 1 commit into from
Aug 10, 2021

Conversation

alculquicondor
Copy link
Contributor

Add a label for operator name.
Mark non-fully-qualified labels as Deprecated.

Fixes #148

Pending tasks to be done in future releases #149

Add a label for operator name.
Mark non-fully-qualified labels as Deprecated.
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

It's clean.

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 6c9fe11 into kubeflow:master Aug 10, 2021
@alculquicondor
Copy link
Contributor Author

Can we have a new release of this repo?

@Jeffwan
Copy link
Member

Jeffwan commented Aug 11, 2021

Can we have a new release of this repo?

@alculquicondor Here's the diff. v0.3.6...master I think we can cut one release or wait for more features. Can also use commit in go.mod?

@alculquicondor
Copy link
Contributor Author

I would prefer we have a release than using a commit in go.mod

@gaocegege
Copy link
Member

@Jeffwan WDYT, should we have a release after the all-in-one operator is merged?

alculquicondor added a commit to alculquicondor/common that referenced this pull request Aug 12, 2021
Add a label for operator name.
Mark non-fully-qualified labels as Deprecated.
@Jeffwan
Copy link
Member

Jeffwan commented Aug 12, 2021

@gaocegege @alculquicondor I think it's ok to cut a release. We probably need to define release strategy for this repo.

I assume changes like #150 are breaking changes? If job controller is released, on going jobs will be affected.

Do we want to cut 0.3.7 or cut release branch 0.4.0? We didn't cut release branches for this version yet. I think it's time to follow semantic versioning?

@alculquicondor
Copy link
Contributor Author

alculquicondor commented Aug 12, 2021

It's only breaking for the controllers that don't use the common controller. For the ones that do, the new controller still respects the deprecated labels.
But 0.4.0 makes the most sense

@Jeffwan
Copy link
Member

Jeffwan commented Aug 13, 2021

Sounds good. Let's cut release-0.4 branch and cut 0.4.0 tag for the new release. sounds good to you? @gaocegege

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use fully-qualified labels
5 participants