-
Notifications
You must be signed in to change notification settings - Fork 73
Add fully-qualified labels #150
Add fully-qualified labels #150
Conversation
Add a label for operator name. Mark non-fully-qualified labels as Deprecated.
0bd38fd
to
7375e73
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
It's clean.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can we have a new release of this repo? |
@alculquicondor Here's the diff. v0.3.6...master I think we can cut one release or wait for more features. Can also use commit in go.mod? |
I would prefer we have a release than using a commit in go.mod |
@Jeffwan WDYT, should we have a release after the all-in-one operator is merged? |
Add a label for operator name. Mark non-fully-qualified labels as Deprecated.
@gaocegege @alculquicondor I think it's ok to cut a release. We probably need to define release strategy for this repo. I assume changes like #150 are breaking changes? If job controller is released, on going jobs will be affected. Do we want to cut 0.3.7 or cut release branch 0.4.0? We didn't cut release branches for this version yet. I think it's time to follow semantic versioning? |
It's only breaking for the controllers that don't use the common controller. For the ones that do, the new controller still respects the deprecated labels. |
Sounds good. Let's cut |
Add a label for operator name.
Mark non-fully-qualified labels as Deprecated.
Fixes #148
Pending tasks to be done in future releases #149