fix job active count; count terminating pod as failed #214
Conversation
|
@yowenter And also, can you update the unit test? https://github.com/kubeflow/common/blob/master/pkg/controller.v1/common/status_test.go |
Hi, @tenzen-y, I've added job status unittest, please review again. |
There was a problem hiding this comment.
@yowenter Looks great! Thank you!
/lgtm
/assign @terrytangyuan
| setStatusForTest(&jobStatus, "worker", 2, 3, 1) | ||
| assert.Equal(t, jobStatus.ReplicaStatuses["worker"].Failed, int32(2)) | ||
| setStatusForTest(&jobStatus, "worker", 2, 3, 1, 1) | ||
| // terminating pod should count as failed. |
|
/lgtm cancel |
Signed-off-by: yowenter <wenter.wu@gmail.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
if pod is terminating , the pod.Status.Phase is still RUNNING.
In this case, the Job status maybe not correct.