kfctl build doesn't create all the istio_dex config

[ryandawsonuk]

I do:

export CONFIG=https://raw.githubusercontent.com/kubeflow/manifests/master/kfdef/kfctl_istio_dex.yaml
kfctl build -f ${CONFIG} -V

The generated kustomize config should contain a folder titled 'istio' as my old build do:

But there is no such directory when I do a new build now. All the others are there, it's just this one that is missing. The result is that when I do a kfctl apply from the generated kfapp I get:

ERRO[0018] error evaluating kustomization manifest for istio Error absolute path error in '../kustomize/istio' : evalsymlink failure on '../kustomize/istio' : lstat /home/ryan/Documents/src/seldon-deploy/seldonctl/seldon-deploy-install/prerequisites-setup/tempresources/kf-install/kfapp/kustomize/istio: no such file or directory  filename="kustomize/kustomize.go:173"
Error: failed to apply:  (kubeflow.error): Code 500 with message: kfApp Apply failed for kustomize:  (kubeflow.error): Code 500 with message: error evaluating kustomization manifest for istio Error absolute path error in '../kustomize/istio' : evalsymlink failure on '../kustomize/istio' : lstat /home/ryan/Documents/src/seldon-deploy/seldonctl/seldon-deploy-install/prerequisites-setup/tempresources/kf-install/kfapp/kustomize/istio: no such file or directory

[jtfogarty]

/area kfctl
/kind bug
/priority p1

[yanniszark]

It seems that this is the offending commit kubeflow/manifests@f925259#diff-22a62b4046d14c9056c87c46260349d7 introduced in PR kubeflow/manifests#620.

cc @krishnadurai

[krishnadurai]

@ryandawsonuk Thanks for reporting this issue. I've added a fix here: kubeflow/manifests#704