Skip to content
This repository has been archived by the owner on Aug 17, 2023. It is now read-only.

pretty print log messages IAM policy #327

Closed

Conversation

Anamika28
Copy link

Existing pretty print function is utilised in places, where logs need to be printed in json format.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@kubeflow-bot
Copy link

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign yanniszark
You can assign the PR to them by writing /assign @yanniszark in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @Anamika28. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Jeffwan
Copy link
Member

Jeffwan commented May 11, 2020

@Anamika28 Thanks for the contribution. Could you sign CLA? seems kfutils.PrettyPrint just return one result, let's have one line for it

log.Infof("ManagedCluster set defaulting to %v", kfutils.PrettyPrint(*awsPluginSpec.ManagedCluster))

@Jeffwan
Copy link
Member

Jeffwan commented Jun 21, 2020

@Anamika28 Do you want to rebase change and sign CLA?

Jeffwan added a commit to Jeffwan/kfctl that referenced this pull request Jun 23, 2020
Jeffwan added a commit to Jeffwan/kfctl that referenced this pull request Jun 23, 2020
@Jeffwan
Copy link
Member

Jeffwan commented Jun 29, 2020

Can not reach out the original author. I replicate a PR #362 to resolve this issue.

/close

@k8s-ci-robot
Copy link
Contributor

@Jeffwan: Closed this PR.

In response to this:

Can not reach out the original author. I replicate a PR #362 to resolve this issue.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Jeffwan added a commit to Jeffwan/kfctl that referenced this pull request Jun 29, 2020
Jeffwan added a commit to Jeffwan/kfctl that referenced this pull request Jun 29, 2020
k8s-ci-robot pushed a commit that referenced this pull request Jun 29, 2020
* Add region into IRSA role name (#359)

* Add Support for AWS Dex Basic-Authentication (#357)

* Pretty print log messages IAM policy(from #327) (#362)
@Anamika28
Copy link
Author

Anamika28 commented Jun 29, 2020 via email

vpavlin pushed a commit to vpavlin/kfctl that referenced this pull request Jul 10, 2020
vpavlin pushed a commit to vpavlin/kfctl that referenced this pull request Jul 20, 2020
vpavlin pushed a commit to vpavlin/kfctl that referenced this pull request Jul 22, 2020
vpavlin pushed a commit to vpavlin/kfctl that referenced this pull request Jul 22, 2020
crobby pushed a commit to crobby/kfctl that referenced this pull request Feb 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants