Skip to content
This repository has been archived by the owner on Aug 17, 2023. It is now read-only.

Turn the remove-namespace kustomize function into a proper function. #388

Merged
merged 1 commit into from
Aug 4, 2020

Conversation

jlewi
Copy link
Contributor

@jlewi jlewi commented Jul 31, 2020

  • Use a client side CRD so we can easily add more types
    for which we need to remove the namespace.

  • Package it in the same docker image as our image-prefix kpt function.

Fix GoogleCloudPlatform/kubeflow-distribution#27

* Use a client side CRD so we can easily add more types
  for which we need to remove the namespace.

* Package it in the same docker image as our image-prefix kpt function.

Fix GoogleCloudPlatform/kubeflow-distribution#27
@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubeflow-bot
Copy link

This change is Reviewable

@jlewi
Copy link
Contributor Author

jlewi commented Jul 31, 2020

Not ready for review but creating a PR so I don't forget about it.

@jlewi jlewi marked this pull request as ready for review August 3, 2020 15:17
@jlewi
Copy link
Contributor Author

jlewi commented Aug 3, 2020

/assign @Bobgy

This is ready for review.

@Bobgy
Copy link
Contributor

Bobgy commented Aug 4, 2020

/lgtm
/approve

@jlewi
Copy link
Contributor Author

jlewi commented Aug 4, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

@jlewi: you cannot LGTM your own PR.

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy, jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 18d3ee8 into kubeflow:master Aug 4, 2020
crobby pushed a commit to crobby/kfctl that referenced this pull request Feb 25, 2021
…ubeflow#388)

* Use a client side CRD so we can easily add more types
  for which we need to remove the namespace.

* Package it in the same docker image as our image-prefix kpt function.

Fix GoogleCloudPlatform/kubeflow-distribution#27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ACM] Create a kustomize function to remove namespace from cluster scoped CRs
4 participants