Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for conditions #33

Closed
drewbutlerbb4 opened this issue Mar 18, 2020 · 5 comments · Fixed by #105
Closed

Add support for conditions #33

drewbutlerbb4 opened this issue Mar 18, 2020 · 5 comments · Fixed by #105
Assignees

Comments

@drewbutlerbb4
Copy link
Member

Add support for condition resources: https://github.com/tektoncd/pipeline/blob/master/docs/conditions.md

A direct example in kfp: https://github.com/kubeflow/pipelines/blob/0.2.2/samples/core/condition/condition.py

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
feature 1.00

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@drewbutlerbb4
Copy link
Member Author

/assign @drewbutlerbb4

@animeshsingh
Copy link
Collaborator

/label compiler

@k8s-ci-robot
Copy link

@animeshsingh: The label(s) /label compiler cannot be applied. These labels are supported: api-review, community/discussion, community/maintenance, community/question, cuj/build-train-deploy, cuj/multi-user, platform/aws, platform/azure, platform/gcp, platform/minikube, platform/other, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash

In response to this:

/label compiler

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@drewbutlerbb4
Copy link
Member Author

This issue will remain after #84 because conditions that receive parameters from task outputs still fail. Once this issue is fixed another PR will be made to reconcile.

gmfrasca pushed a commit to gmfrasca/data-science-pipelines-tekton that referenced this issue Sep 27, 2022
Adding Probes to ML Pipelines' pods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants