Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transformer test for pod annotations and labels use case #76

Merged
merged 1 commit into from
Apr 1, 2020

Conversation

Tomcli
Copy link
Member

@Tomcli Tomcli commented Mar 31, 2020

No description provided.

@kubeflow-bot
Copy link

This change is Reviewable

@Tomcli
Copy link
Member Author

Tomcli commented Mar 31, 2020

/assign @ckadner

Copy link
Member

@ckadner ckadner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thanks @Tomcli

/lgtm

@ckadner
Copy link
Member

ckadner commented Apr 1, 2020

/assign @animeshsingh

@ckadner ckadner removed their assignment Apr 1, 2020
@animeshsingh
Copy link
Collaborator

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: animeshsingh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6df545a into kubeflow:master Apr 1, 2020
@ckadner ckadner mentioned this pull request Apr 1, 2020
27 tasks
@Tomcli Tomcli deleted the add_tests branch May 20, 2020 17:20
gmfrasca pushed a commit to gmfrasca/data-science-pipelines-tekton that referenced this pull request May 16, 2023
Include permission for get services
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants