-
Notifications
You must be signed in to change notification settings - Fork 2.4k
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Jupyter web app to utilize the common code #5310
Comments
Issue-Label Bot is automatically applying the labels:
Please mark this comment with 👍 or 👎 to give our bot feedback! |
1 similar comment
Issue-Label Bot is automatically applying the labels:
Please mark this comment with 👍 or 👎 to give our bot feedback! |
/assign kimwnasptd |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@kimwnasptd I believe this issue can be (almost) closed. |
Yes it can most certainly be closed. I think all of the above bullets are satisfied so we can move along and close this /close |
@kimwnasptd: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind feature
Why you need this feature:
We've already created a common Python package for the backend #5164 and an Angular library for the frontend #5252 . We also decided to move our CRUD web apps under the
/components/crud-web-apps
directory #5183.Following up, we should refactor both the frontend and the backend of JWA to utilize this code. This will help us reduce code duplication significantly and it will also reduce friction on adding new features going forward, since the common logic will be moved elsewhere.
This will be used as a tracking issue for this effort.
Describe the solution you'd like:
The changes that need to be done are the following, the order matters:
/components/jupyter-web-app
to ensure that the two apps will be synced in terms of featuresnotebooks
folder under the/components/crud-web-apps
that will contain the code for the refactored Jupyter web app./components/crud-web-apps/jupyter/backend
/components/crud-web-apps/jupyter/frontend
After that we should continue adding new features to the newest web app.
Anything else you would like to add:
cc @jlewi @jbottum @thesuperzapper
The text was updated successfully, but these errors were encountered: