Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Jupyter web app to utilize the common code #5310

Closed
6 of 7 tasks
kimwnasptd opened this issue Sep 16, 2020 · 7 comments
Closed
6 of 7 tasks

Refactor Jupyter web app to utilize the common code #5310

kimwnasptd opened this issue Sep 16, 2020 · 7 comments
Assignees
Labels

Comments

@kimwnasptd
Copy link
Member

kimwnasptd commented Sep 16, 2020

/kind feature

Why you need this feature:
We've already created a common Python package for the backend #5164 and an Angular library for the frontend #5252 . We also decided to move our CRUD web apps under the /components/crud-web-apps directory #5183.

Following up, we should refactor both the frontend and the backend of JWA to utilize this code. This will help us reduce code duplication significantly and it will also reduce friction on adding new features going forward, since the common logic will be moved elsewhere.

This will be used as a tracking issue for this effort.

Describe the solution you'd like:
The changes that need to be done are the following, the order matters:

  • Stop adding more features to /components/jupyter-web-app to ensure that the two apps will be synced in terms of features
  • Create a new notebooks folder under the /components/crud-web-apps that will contain the code for the refactored Jupyter web app.
  • PR the refactored backend code under /components/crud-web-apps/jupyter/backend
  • PR the refactored frontend code under /components/crud-web-apps/jupyter/frontend
  • PR the required {Docker,Make}files as well as READMEs
  • Update the CI to build the new web app when the source code is modified from a new PR
  • Update our manifests to use the refactored web app

After that we should continue adding new features to the newest web app.

Anything else you would like to add:

  • The refactored web app will be identical to the current one and it should provide the same functionality the current one does.
  • We should be creating issues for each one of the above steps and link them to this one so we can keep track of the work getting done on this
  • I'm aiming to have this work merged for Kubeflow 1.2, as well as many of the features from jupyter-web-app rewrite #5280
  • We (Arrikto) have already been using this new web app for MiniKF and have tested it extensively

cc @jlewi @jbottum @thesuperzapper

@issue-label-bot issue-label-bot bot added the area/jupyter Issues related to Jupyter label Sep 16, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
area/jupyter 0.96

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

1 similar comment
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
area/jupyter 0.96

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@kimwnasptd
Copy link
Member Author

/assign kimwnasptd

@stale
Copy link

stale bot commented Feb 2, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale label Feb 2, 2021
@davidspek
Copy link
Contributor

@kimwnasptd I believe this issue can be (almost) closed.

@stale stale bot removed the lifecycle/stale label Mar 20, 2021
@kimwnasptd
Copy link
Member Author

Yes it can most certainly be closed. I think all of the above bullets are satisfied so we can move along and close this

/close

@google-oss-robot
Copy link

@kimwnasptd: Closing this issue.

In response to this:

Yes it can most certainly be closed. I think all of the above bullets are satisfied so we can move along and close this

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants