Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherrypick to 0.5 #2849

Merged
merged 13 commits into from Mar 28, 2019
Merged

Cherrypick to 0.5 #2849

merged 13 commits into from Mar 28, 2019

Conversation

lluunn
Copy link
Contributor

@lluunn lluunn commented Mar 28, 2019

Cherrypick all PRs from 03/26 to now into 0.5

(PR2787 on 03/26 already cherrypicked before.)

See master commits:
https://github.com/kubeflow/kubeflow/commits/master

And 0.5 commits:
https://github.com/kubeflow/kubeflow/commits/v0.5-branch

/cc @jlewi


This change is Reviewable

jlewi and others added 13 commits March 28, 2019 13:16
…2795)

* Extend the E2E test for the go binary to verify that Kubeflow is deployed.

* Related to kubeflow#2610 E2E test for go binary.

* Create kf_is_ready_test.py to verify that Kubeflow is deployed successfully.
* We don't reuse wait_for_kubeflow.py because that is configured to wait
  on JupyterHub.

  * We could have modified wait_for_kubeflow.py but I took this as an
    opportunity to convert the test to use pytest.

* We don't run the component tests because those are currently configured
  to depend on wait_for_kubeflow.py. So we will modify them in a follow
  on PR.

* kfctl_delete is now passing so enable it.

* Address comments.

* Disable katib stduy job test because it is flaky (Related to kubeflow#2825).
* update some image for 0.5

* update tfjob
* AddNamedContext

* temp

* add namespace

* optionally write to KUBECONFIG

* updates

* revert

* add verify_kubeconfig

* log

* add strip

* fix

* call AddNamedContext in Apply
…127.0.0.1' (kubeflow#2813)

* fixes 'kfctl apply fails to create k8s resources; tries to deploy to 127.0.0.1'

* remove run_with_retries for kfctl_go_test kfctl apply use case
* Add an E2E test for kfctl with IAP on GCP.

Related to: kubeflow#2610 E2E test for kfctl.

* Make test names unique based on parameters.

* Revert to pulling HEAD.

* Fix comment.

* Set requests & limits.

* Increase timeout.

* Add a comment.
* use YAML support for IAM bindings

* write to iam_bindings.yaml

* yaml config to cluster-kubeflow

* yaml support to storage-kubeflow

* comments

* fix

* add desc
…ubeflow#2810)

* call package manager, then platform in delete. Allow ksonnet to delete k8s

* fix logic around deletion of ALL and PLATFORM

* compilation error

* convert to KfError on error returns

* update on code comments, make sure all errors are returned as KfError
@k8s-ci-robot k8s-ci-robot requested a review from jlewi March 28, 2019 20:20
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: lluunn

If they are not already assigned, you can assign the PR to them by writing /assign @lluunn in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@lluunn
Copy link
Contributor Author

lluunn commented Mar 28, 2019

/cc @richardsliu @kunmingg

@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@lluunn lluunn merged commit 5c6498a into kubeflow:v0.5-branch Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants