Support extra arguments in kfctl_e2e_workflow.py #4335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* See kubeflow/testing#489 we want to support having run_e2e_workflow.py pass extra arguments to the workflow. To do that we need to update the test to first accept unknown arguments so we don't break once run_e2e_workflow.py starts adding extra arguments.
|
/assign @lluunn |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lluunn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
saffaalvi
pushed a commit
to StatCan/kubeflow
that referenced
this pull request
Feb 11, 2021
* Support extra arguments in kfctl_e2e_workflow.py * See kubeflow/testing#489 we want to support having run_e2e_workflow.py pass extra arguments to the workflow. To do that we need to update the test to first accept unknown arguments so we don't break once run_e2e_workflow.py starts adding extra arguments. * Fix.
saffaalvi
pushed a commit
to StatCan/kubeflow
that referenced
this pull request
Feb 12, 2021
* Support extra arguments in kfctl_e2e_workflow.py * See kubeflow/testing#489 we want to support having run_e2e_workflow.py pass extra arguments to the workflow. To do that we need to update the test to first accept unknown arguments so we don't break once run_e2e_workflow.py starts adding extra arguments. * Fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pass extra arguments to the workflow. To do that we need to update the
test to first accept unknown arguments so we don't break once
run_e2e_workflow.py starts adding extra arguments.
This change is