Skip to content
This repository has been archived by the owner on Dec 2, 2021. It is now read-only.

Fix initial state of LineageViewActionBar #177

Merged

Conversation

kwasi
Copy link
Contributor

@kwasi kwasi commented Dec 2, 2019

Before: https://screenshot.googleplex.com/JtEJ8TJBdEV
After: https://screenshot.googleplex.com/iZNqVrsKkjc

  • Pass ArtifactDetails state artifact to <LineageView />. Artifact is guaranteed to be loaded before attempting to render <LineageView />
  • Make target a required property to render <LineageView />

This change is Reviewable

@kwasi
Copy link
Contributor Author

kwasi commented Dec 2, 2019

/assign @avdaredevil

@kwasi
Copy link
Contributor Author

kwasi commented Dec 2, 2019

/area front-end
/area metadata

@avdaredevil
Copy link
Contributor

Looks great!
/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avdaredevil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f2ec34e into kubeflow:master Dec 2, 2019
@kwasi kwasi deleted the lineage-view-action-bar-initial-state-pr branch December 2, 2019 06:10
@avdaredevil avdaredevil assigned kwasi and unassigned avdaredevil Feb 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants