This repository has been archived by the owner on Dec 2, 2021. It is now read-only.
[Windows] Changes to allow docker building on windows #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwasi
reviewed
Dec 6, 2019
| const main = async _ => { | ||
| const commitHash = (await runCmd('git rev-parse HEAD')).out.trim() | ||
| const date = new Date().toUTCString() | ||
| const protocProcess = spawn( |
There was a problem hiding this comment.
nit: dockerProcess or process
kwasi
reviewed
Dec 6, 2019
| const {exec, spawn} = require('child_process') | ||
| const runCmd = cmd => new Promise((res, rej) => exec(cmd, (e, out, err) => e?rej(e):res({out, err}))) | ||
|
|
||
| // COMMIT_HASH=`git rev-parse HEAD`; docker build -t gcr.io/kubeflow-images-public/metadata-frontend:${COMMIT_HASH} --build-arg COMMIT_HASH=${COMMIT_HASH} --build-arg DATE=\"`date -u`\" . |
|
/lgtm Looks great! Just a couple nits |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kwasi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
avdaredevil
added a commit
to avdaredevil/metadata
that referenced
this pull request
Dec 6, 2019
k8s-ci-robot
pushed a commit
that referenced
this pull request
Dec 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
npm run dockernow runs a new script called./docker_build.jswhich will create the docker images cross-platformdate -uwe now use js'new Date().toUTCString())Release note:
Meta
/area metadata
/area front-end
/priority p1
/assign @avdaredevil
/cc @kwasi
This change is