add specific K8s version when testing with Kind #45
Conversation
.github/workflows/build-image-pr.yml
Outdated
| run: | | ||
| echo "Download kustomize 5.2.1" | ||
| mkdir $GITHUB_WORKSPACE/kustomize | ||
| curl -s "https://raw.githubusercontent.com/kubernetes-sigs/kustomize/master/hack/install_kustomize.sh" | bash -s "5.2.1" "$GITHUB_WORKSPACE/kustomize" |
There was a problem hiding this comment.
I'm concerned about the curl | bash. It's a potential security issue. Isn't there a binary we can download instead? The script is doing that anyway.
There was a problem hiding this comment.
see here: #43 (comment)
| @@ -51,6 +50,7 @@ jobs: | |||
| if: env.BUILD_CONTEXT == 'main' | |||
| shell: bash | |||
| env: | |||
| IMG: ${{ env.IMG_ORG }}/${{ env.IMG_REPO }} | |||
There was a problem hiding this comment.
If the IMG variable doesn't change in the step, it's better to keep it in the global env. wdyt?
There was a problem hiding this comment.
yep, see here: #43 (comment)
Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com>
tarilabs
force-pushed
the
tarilabs-20240319-44
branch
from
0532a24
to
9b39bb3
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rareddy, tarilabs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[pull] main from kubeflow:main
Description
How Has This Been Tested?
uses Kind as part of GHA workflow
Merge criteria: