-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade mod dependencies #364
Comments
Possibly related: #323 |
So I gave it a try, and it seems that volcano is fine (it has a version that builds against 1.19). The problem is kube-batch, used in v1alpha2. I suppose it's not safe to migrate v1alpha2 from kube-batch to volcano, right? |
I tried to upgrade to 1.18, 1.17 and even 1.16. In all of them kube-batch fails to build. Since this dependency nightmare might limit our abilities to iterate the v1 controller, I propose we move it to a separate module https://blog.golang.org/v2-go-modules Or maybe I can just have the new controller proposed in #360 in the new module, solving the question about keeping the old and new "v1" controllers. |
The dependencies were upgraded for the v2 controller #370 /close |
@alculquicondor: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Currently, the operator builds against the 1.15 k8s libraries. Note that currently the oldest supported version of k8s is 1.19
Another dependency is kubeflow/common 0.3.3, which builds against k8s 1.16 libraries. 0.3.4 builds against 1.19
So we could at least upgrade to 1.19 dependencies. This should make it simpler to introduce more dependencies such as controller-runtime for integration and E2E testing #233
However, there is one problematic dependency: kube-batch. While volcano has builds against k8s 1.19, kube-batch (deprecated project) only has builds against 1.16. This dependency is used in the v1alpha2 controller. Hopefully we can still build it using "replace" directives. It might be possible given that we only use the listers from it.
The text was updated successfully, but these errors were encountered: