Pass schedulingPolicy.PriorityClass to Launcher and Workers

[tenzen-y]

/kind feature

Since #520, the mpi-operator respects schedulingPolicy when creating PodGroup.
However, currently, the mpi-operator doesn't pass schedulingPolicy.PriorityClass to Launcher and Workers even if they don't have priorityClass.

So I would like to pass schedulingPolicy.PriorityClass to ReplicaSpec if they don't have priorityClass.

@alculquicondor @terrytangyuan WDYT?

[alculquicondor]

Do we do the same in other training-operator controllers?

I've heard from some people that they prefer to have a job-level priority that it's independent of the pods priority.

[tenzen-y]

Do we do the same in other training-operator controllers?

No, the training-operator doesn't have the same logic.

I've heard from some people that they prefer to have a job-level priority that it's independent of the pods priority.

It makes sense. It might be better to keep the current logic.

[tenzen-y]

/close

[google-oss-prow]

@tenzen-y: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.