Set ClusterFirstWithHostNet DNS policy when the Pods use host network. #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alculquicondor
force-pushed
the
cluster-domain
branch
from
bc260ae
to
9f3def5
Compare
Use 2222 by default. This should make it easier to use host networks, as generally the port 22 is taken by the host's sshd.
when the Pods use host network. This allows resolving the worker and launcher hostnames without needing to include the namespace or cluster domain.
alculquicondor
force-pushed
the
cluster-domain
branch
from
9f3def5
to
3742a3d
Compare
gaocegege
reviewed
Sep 14, 2021
|
Some users might choose host network for extra network performance. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows resolving the worker and launcher hostnames without needing to include the namespace or cluster domain.
Also migrated the base image to use port 2222, as port 22 is usually taken by the host's sshd. This should make it easier for pods to use host network.
Fixes #427