-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ws): initial commit for controller #5
feat(ws): initial commit for controller #5
Conversation
Signed-off-by: Jiri Daněk <jdanek@redhat.com>
Signed-off-by: Jiri Daněk <jdanek@redhat.com>
@jiridanek I have made a new branch, which we can develop in (rather than |
Signed-off-by: Jiri Daněk <jdanek@redhat.com>
Signed-off-by: Jiri Daněk <jdanek@redhat.com>
Signed-off-by: Jiri Daněk <jdanek@redhat.com>
Signed-off-by: Jiri Daněk <jdanek@redhat.com>
Co-authored-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com> Signed-off-by: Jiri Daněk <jdanek@redhat.com>
Signed-off-by: Jiri Daněk <jdanek@redhat.com>
https://github.com/kubernetes-sigs/kubebuilder/releases/tag/v3.15.0 Signed-off-by: Jiri Daněk <jdanek@redhat.com>
golang.org/x/tools v0.16.1 // indirect | ||
gomodules.xyz/jsonpatch/v2 v2.4.0 // indirect | ||
google.golang.org/appengine v1.6.7 // indirect | ||
google.golang.org/protobuf v1.31.0 // indirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there happens to be a cve against this protobuf version; I guess we can fix it with dependabot or something like that
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: thesuperzapper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
* feat: Generate kubebuilder project Signed-off-by: Jiri Daněk <jdanek@redhat.com> * fixup add unittests gha Signed-off-by: Jiri Daněk <jdanek@redhat.com> * fixup disable permissions for all of the available scopes Signed-off-by: Jiri Daněk <jdanek@redhat.com> * fixup add triggers for release branches Signed-off-by: Jiri Daněk <jdanek@redhat.com> * fixup remove duplicated gitignores Signed-off-by: Jiri Daněk <jdanek@redhat.com> * fixup remove workflow dispatch Signed-off-by: Jiri Daněk <jdanek@redhat.com> * Apply suggestions from code review Co-authored-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com> Signed-off-by: Jiri Daněk <jdanek@redhat.com> * fixup rename the project to workspace-controller Signed-off-by: Jiri Daněk <jdanek@redhat.com> * fixup update kubebuilder to 3.15 https://github.com/kubernetes-sigs/kubebuilder/releases/tag/v3.15.0 Signed-off-by: Jiri Daněk <jdanek@redhat.com> --------- Signed-off-by: Jiri Daněk <jdanek@redhat.com> Signed-off-by: Adem Baccara <adembc020@gmail.com>
Co-authored-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com> Signed-off-by: Jiri Daněk <jdanek@redhat.com>
TODO:
integration test with kind (kubeflow/kubeflow notebooks controller has that)make test-e2e
on GitHub Actions #11Translate the current CRD specWorkspace
andWorkspaceKind
CRD scaffolds #6maybe something else from https://docs.google.com/document/d/1SiWLah-U07hAc47sSsoI8-NkbkLnHl1YVzxw193QUKE/edit#heading=h.naudedl8te2q