Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ws): initial commit for controller #5

Merged
merged 9 commits into from
May 23, 2024

Conversation

jiridanek
Copy link
Member

@jiridanek jiridanek commented May 13, 2024

cd workspaces/controller
go mod init github.com/kubeflow/notebooks/workspaces/controller
kubebuilder init \
    --plugins=go/v4 \
    --domain=kubeflow.org \
    --project-name=workspace-controller \
    --repo=github.com/kubeflow/notebooks/workspaces/controller
kubebuilder create api --version v1beta1 --kind Workspace
kubebuilder create api --version v1beta1 --kind WorkspaceKind
make manifests

TODO:

maybe something else from https://docs.google.com/document/d/1SiWLah-U07hAc47sSsoI8-NkbkLnHl1YVzxw193QUKE/edit#heading=h.naudedl8te2q

Signed-off-by: Jiri Daněk <jdanek@redhat.com>
Signed-off-by: Jiri Daněk <jdanek@redhat.com>
@thesuperzapper
Copy link
Member

@jiridanek I have made a new branch, which we can develop in (rather than main), please make your PR into: https://github.com/kubeflow/notebooks/tree/notebooks-v2

@jiridanek jiridanek changed the base branch from main to notebooks-v2 May 13, 2024 19:19
Signed-off-by: Jiri Daněk <jdanek@redhat.com>
Signed-off-by: Jiri Daněk <jdanek@redhat.com>
Signed-off-by: Jiri Daněk <jdanek@redhat.com>
@thesuperzapper thesuperzapper changed the title feat(nb): Initialize new kubebuilder controller in workspaces/controller feat(ws): Initialize new kubebuilder controller in workspaces/controller May 23, 2024
@thesuperzapper thesuperzapper changed the title feat(ws): Initialize new kubebuilder controller in workspaces/controller feat(ws): initial commit for controller May 23, 2024
workspaces/controller/.gitignore Outdated Show resolved Hide resolved
.github/workflows/workspaces-controller_unit-tests.yaml Outdated Show resolved Hide resolved
workspaces/controller/README.md Outdated Show resolved Hide resolved
workspaces/controller/README.md Outdated Show resolved Hide resolved
workspaces/controller/README.md Outdated Show resolved Hide resolved
workspaces/controller/README.md Outdated Show resolved Hide resolved
workspaces/controller/cmd/main.go Outdated Show resolved Hide resolved
workspaces/controller/config/default/kustomization.yaml Outdated Show resolved Hide resolved
Signed-off-by: Jiri Daněk <jdanek@redhat.com>
Co-authored-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

Signed-off-by: Jiri Daněk <jdanek@redhat.com>
Signed-off-by: Jiri Daněk <jdanek@redhat.com>
golang.org/x/tools v0.16.1 // indirect
gomodules.xyz/jsonpatch/v2 v2.4.0 // indirect
google.golang.org/appengine v1.6.7 // indirect
google.golang.org/protobuf v1.31.0 // indirect
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there happens to be a cve against this protobuf version; I guess we can fix it with dependabot or something like that

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thesuperzapper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thesuperzapper
Copy link
Member

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label May 23, 2024
@google-oss-prow google-oss-prow bot merged commit 20a3de3 into kubeflow:notebooks-v2 May 23, 2024
3 checks passed
Adembc pushed a commit to Adembc/notebooks that referenced this pull request Jun 2, 2024
* feat: Generate kubebuilder project

Signed-off-by: Jiri Daněk <jdanek@redhat.com>

* fixup add unittests gha

Signed-off-by: Jiri Daněk <jdanek@redhat.com>

* fixup disable permissions for all of the available scopes

Signed-off-by: Jiri Daněk <jdanek@redhat.com>

* fixup add triggers for release branches

Signed-off-by: Jiri Daněk <jdanek@redhat.com>

* fixup remove duplicated gitignores

Signed-off-by: Jiri Daněk <jdanek@redhat.com>

* fixup remove workflow dispatch

Signed-off-by: Jiri Daněk <jdanek@redhat.com>

* Apply suggestions from code review

Co-authored-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

Signed-off-by: Jiri Daněk <jdanek@redhat.com>

* fixup rename the project to workspace-controller

Signed-off-by: Jiri Daněk <jdanek@redhat.com>

* fixup update kubebuilder to 3.15

https://github.com/kubernetes-sigs/kubebuilder/releases/tag/v3.15.0

Signed-off-by: Jiri Daněk <jdanek@redhat.com>

---------

Signed-off-by: Jiri Daněk <jdanek@redhat.com>
Signed-off-by: Adem Baccara <adembc020@gmail.com>
jiridanek added a commit to jiridanek/notebooks-v2 that referenced this pull request Jun 17, 2024
Co-authored-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Signed-off-by: Jiri Daněk <jdanek@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants