test: Moved kfp-kubernetes-execution-tests to GitHub Actions #10926

hbelmiro · 2024-06-18T20:25:57Z

Description of your changes:
Moved kfp-kubernetes-execution-tests to GitHub Actions.

Resolves: #10921

Implementation notes

I had to use Ubuntu 24.04 because the default (22.04) has an old and non-compatible version of protobuf-compiler.
- apt-get update was not enough to get it updated
- I also tried to manually install the binary, but it didn't work
- Python 3.8 is not available in the Ubuntu 24.04 runner. So I used 3.9.

PR to update GoogleCloudPlatform/oss-test-infra

chore: Remove KFP presubmit kfp-kubernetes-execution-tests tests prow config GoogleCloudPlatform/oss-test-infra#2304

Checklist:

The title for your pull request (PR) should follow our title convention. Learn more about the pull request title convention used in this repository.

google-oss-prow · 2024-06-18T20:26:00Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

hbelmiro · 2024-06-18T20:33:46Z

/assign @DharmitD @chensun

rimolive · 2024-06-18T21:02:11Z

@hbelmiro Prow tests run kfp-kubernetes testing using Python 3.8 to 3.12. From what I can see in this PR, GHA kfp-kubernetes testing is not checking Python 3.8. Can you add this version too?

hbelmiro · 2024-06-18T21:29:34Z

@hbelmiro Prow tests run kfp-kubernetes testing using Python 3.8 to 3.12. From what I can see in this PR, GHA kfp-kubernetes testing is not checking Python 3.8. Can you add this version too?

@rimolive I added a note about that in the description of the PR.

DharmitD

/lgtm

@hbelmiro could you make a PR to the oss-test-infra repo in parallel to remove these tests from Prow?

@chensun could you take a look? Thanks.

hbelmiro · 2024-06-25T13:08:57Z

cc @chensun @zijianjoy @james-jwu

hbelmiro · 2024-06-26T18:06:23Z

/hold for rebasing after #10946 gets merged.

hbelmiro · 2024-06-29T14:11:55Z

/unhold
/approve

hbelmiro · 2024-06-29T14:13:15Z

We still need your approval on this @chensun.

DharmitD

/Approve

.github/workflows/kfp-kubernetes-execution-tests.yml

google-oss-prow · 2024-07-02T17:11:59Z

@hbelmiro: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
kfp-kubernetes-execution-tests	`ad17aca`	link	false	`/test kfp-kubernetes-execution-tests`

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

DharmitD

/lgtm

rimolive · 2024-07-02T19:29:42Z

/approve

hbelmiro · 2024-07-11T20:28:39Z

Needs approval from an approver in each of these files:

* ~[.github/OWNERS](https://github.com/kubeflow/pipelines/blob/master/.github/OWNERS)~ [DharmitD,hbelmiro]

* **[kubernetes_platform/OWNERS](https://github.com/kubeflow/pipelines/blob/master/kubernetes_platform/OWNERS)**

* ~[test/OWNERS](https://github.com/kubeflow/pipelines/blob/master/test/OWNERS)~ [DharmitD,hbelmiro]

@connor-mccarthy we need approval from one of you guys.

.github/workflows/kfp-kubernetes-execution-tests.yml

diegolovison · 2024-07-15T17:45:51Z

/lgtm

hbelmiro · 2024-07-17T14:20:45Z

@james-jwu can you help me to get this approved?

DharmitD · 2024-07-29T02:42:45Z

@chensun could you please approve? Thank you!

DharmitD

/Approve

google-oss-prow · 2024-07-29T19:31:24Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DharmitD, hbelmiro, rimolive

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~.github/OWNERS~~ [DharmitD,hbelmiro]
~~kubernetes_platform/OWNERS~~ [hbelmiro]
~~test/OWNERS~~ [DharmitD,hbelmiro]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: hbelmiro <helber.belmiro@gmail.com>

hbelmiro · 2024-07-30T12:52:09Z

@DharmitD can you re-lgtm?

DharmitD

/lgtm

…w#10926) * Moved kfp-kubernetes-execution-tests to GitHub Actions Signed-off-by: hbelmiro <helber.belmiro@gmail.com> * Removed Python versions matrix Signed-off-by: hbelmiro <helber.belmiro@gmail.com> --------- Signed-off-by: hbelmiro <helber.belmiro@gmail.com>

google-oss-prow bot added the do-not-merge/work-in-progress label Jun 18, 2024

google-oss-prow bot requested review from gkcalat, jlyaoyuli and zijianjoy June 18, 2024 20:26

google-oss-prow bot added the size/L label Jun 18, 2024

hbelmiro marked this pull request as ready for review June 18, 2024 20:27

google-oss-prow bot removed the do-not-merge/work-in-progress label Jun 18, 2024

google-oss-prow bot requested a review from chensun June 18, 2024 20:27

google-oss-prow bot assigned chensun and DharmitD Jun 18, 2024

DharmitD reviewed Jun 18, 2024

View reviewed changes

google-oss-prow bot added the lgtm label Jun 18, 2024

hbelmiro mentioned this pull request Jun 19, 2024

chore: Remove KFP presubmit kfp-kubernetes-execution-tests tests prow config GoogleCloudPlatform/oss-test-infra#2304

Merged

hbelmiro mentioned this pull request Jun 26, 2024

chore: Added @rimolive, @hbelmiro and @DharmitD as approvers and reviewers for GitHub Actions #10963

Merged

1 task

google-oss-prow bot added the do-not-merge/hold label Jun 26, 2024

google-oss-prow bot removed the do-not-merge/hold label Jun 29, 2024

DharmitD approved these changes Jul 1, 2024

View reviewed changes

DharmitD reviewed Jul 2, 2024

View reviewed changes

.github/workflows/kfp-kubernetes-execution-tests.yml Outdated Show resolved Hide resolved

hbelmiro force-pushed the kfp-kubernetes-execution-tests-gha branch from a965f78 to 1737ef5 Compare July 2, 2024 16:21

google-oss-prow bot removed the lgtm label Jul 2, 2024

DharmitD reviewed Jul 2, 2024

View reviewed changes

google-oss-prow bot added the lgtm label Jul 2, 2024

diegolovison suggested changes Jul 15, 2024

View reviewed changes

.github/workflows/kfp-kubernetes-execution-tests.yml Show resolved Hide resolved

google-oss-prow bot assigned diegolovison Jul 15, 2024

hbelmiro mentioned this pull request Jul 15, 2024

test: Add script and GitHub Action for kfp-kubernetes-library #11006

Merged

DharmitD approved these changes Jul 29, 2024

View reviewed changes

google-oss-prow bot added the approved label Jul 29, 2024

hbelmiro added 2 commits July 30, 2024 09:30

Moved kfp-kubernetes-execution-tests to GitHub Actions

7b1ee86

Signed-off-by: hbelmiro <helber.belmiro@gmail.com>

Removed Python versions matrix

b590989

Signed-off-by: hbelmiro <helber.belmiro@gmail.com>

hbelmiro force-pushed the kfp-kubernetes-execution-tests-gha branch from ad17aca to b590989 Compare July 30, 2024 12:30

google-oss-prow bot removed the lgtm label Jul 30, 2024

DharmitD reviewed Jul 30, 2024

View reviewed changes

google-oss-prow bot added the lgtm label Jul 30, 2024

google-oss-prow bot merged commit e940ba2 into kubeflow:master Jul 30, 2024
9 checks passed

hbelmiro deleted the kfp-kubernetes-execution-tests-gha branch July 30, 2024 14:25

This was referenced Jul 30, 2024

Move kubeflow-pipelines-manifests to GitHub Actions #11051

Closed

Move kubeflow-pipelines-integration-v2 to GitHub Actions #11052

Closed

Move kubeflow-pipelines-samples-v2 to GitHub Actions #11054

Closed

This was referenced Aug 30, 2024

[bug] Move test-run-all-gcpc-modules to GitHub Actions #11154

Closed

test: Move run-all-gcpc-modules to GitHub Actions #11157

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: Moved kfp-kubernetes-execution-tests to GitHub Actions #10926

test: Moved kfp-kubernetes-execution-tests to GitHub Actions #10926

hbelmiro commented Jun 18, 2024 •

edited

Loading

google-oss-prow bot commented Jun 18, 2024

hbelmiro commented Jun 18, 2024

rimolive commented Jun 18, 2024

hbelmiro commented Jun 18, 2024

DharmitD left a comment

hbelmiro commented Jun 25, 2024

hbelmiro commented Jun 26, 2024

hbelmiro commented Jun 29, 2024

hbelmiro commented Jun 29, 2024

DharmitD left a comment

google-oss-prow bot commented Jul 2, 2024

DharmitD left a comment

rimolive commented Jul 2, 2024

hbelmiro commented Jul 11, 2024

diegolovison commented Jul 15, 2024

hbelmiro commented Jul 17, 2024

DharmitD commented Jul 29, 2024

DharmitD left a comment

google-oss-prow bot commented Jul 29, 2024

hbelmiro commented Jul 30, 2024

DharmitD left a comment

test: Moved kfp-kubernetes-execution-tests to GitHub Actions #10926

test: Moved kfp-kubernetes-execution-tests to GitHub Actions #10926

Conversation

hbelmiro commented Jun 18, 2024 • edited Loading

Implementation notes

PR to update GoogleCloudPlatform/oss-test-infra

google-oss-prow bot commented Jun 18, 2024

hbelmiro commented Jun 18, 2024

rimolive commented Jun 18, 2024

hbelmiro commented Jun 18, 2024

DharmitD left a comment

Choose a reason for hiding this comment

hbelmiro commented Jun 25, 2024

hbelmiro commented Jun 26, 2024

hbelmiro commented Jun 29, 2024

hbelmiro commented Jun 29, 2024

DharmitD left a comment

Choose a reason for hiding this comment

google-oss-prow bot commented Jul 2, 2024

DharmitD left a comment

Choose a reason for hiding this comment

rimolive commented Jul 2, 2024

hbelmiro commented Jul 11, 2024

diegolovison commented Jul 15, 2024

hbelmiro commented Jul 17, 2024

DharmitD commented Jul 29, 2024

DharmitD left a comment

Choose a reason for hiding this comment

google-oss-prow bot commented Jul 29, 2024

hbelmiro commented Jul 30, 2024

DharmitD left a comment

Choose a reason for hiding this comment

hbelmiro commented Jun 18, 2024 •

edited

Loading