Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make kubernetes a dependency of kfp package. #133

Merged
merged 2 commits into from
Nov 7, 2018
Merged

Make kubernetes a dependency of kfp package. #133

merged 2 commits into from
Nov 7, 2018

Conversation

qimingj
Copy link
Contributor

@qimingj qimingj commented Nov 7, 2018

This change is Reviewable

Copy link
Contributor

@gaoning777 gaoning777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaoning777
Copy link
Contributor

/lgtm

@qimingj
Copy link
Contributor Author

qimingj commented Nov 7, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qimingj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qimingj qimingj merged commit ef984d0 into master Nov 7, 2018
@qimingj qimingj deleted the sdk5 branch November 7, 2018 19:01
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
* add kubeflow_label.yml for label sycn across repos in kubeflow, along with helper script to generate it.

* reformat process_label.py to fix pylint check

* handle code review feedback & change code to python3

* add kunmingg as owner and reviewer
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants