Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK/Client - Removed import six #425

Merged
merged 1 commit into from
Nov 30, 2018

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Nov 30, 2018

We're only supporting Python 3.5+. We never supported Python 2.

The reason I want to remove six is because it's not a included in the standard package python image.


This change is Reviewable

@qimingj
Copy link
Contributor

qimingj commented Nov 30, 2018

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 30, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 30, 2018

/retest

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 30, 2018

/test presubmit-e2e-test

@k8s-ci-robot k8s-ci-robot merged commit 4f74ae3 into master Nov 30, 2018
@Ark-kun Ark-kun deleted the avolkov/SDK---Removed-import-six branch January 15, 2019 22:09
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants