Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk.v2): Fix InputPathPlaceholder changed to InputValuePlaceholder #6794

Merged
merged 2 commits into from
Oct 25, 2021

Conversation

chensun
Copy link
Member

@chensun chensun commented Oct 22, 2021

Description of your changes:
Prior to this fix, if you print the value before and after this line:

container_spec = ContainerSpec.parse_obj(implementation)

for example:

print('before: ', implementation)
container_spec = ContainerSpec.parse_obj(implementation)
print('after: ', container_spec)

Then run this unit test:

def test_component_spec_load_from_v1_component_yaml(self):

You'll see that the InputPathPlaceholder(input_name='Input artifact') in implementation changed to InputValuePlaceholder(input_name='Input artifact') in container_spec.

This is caused by the pydantic issue: pydantic/pydantic#2079

Checklist:

@chensun
Copy link
Member Author

chensun commented Oct 22, 2021

As a follow up action item, we need to investigate why the unit test couldn't catch this.

def test_component_spec_load_from_v1_component_yaml(self):

/cc @ji-yaqi

@chensun
Copy link
Member Author

chensun commented Oct 22, 2021

/test kubeflow-pipelines-samples-v2

2 similar comments
@chensun
Copy link
Member Author

chensun commented Oct 23, 2021

/test kubeflow-pipelines-samples-v2

@ji-yaqi
Copy link
Contributor

ji-yaqi commented Oct 24, 2021

/test kubeflow-pipelines-samples-v2

@ji-yaqi
Copy link
Contributor

ji-yaqi commented Oct 24, 2021

/lgtm
/approve
Thanks @chensun for the fix! Will look into the unit test issue.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ji-yaqi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 61fea6b into kubeflow:master Oct 25, 2021
@chensun chensun deleted the fix-continer-spec branch October 25, 2021 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants