-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk)!: move v2 to main namespace #7376
Conversation
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Yaqi, I have a few questions after my first pass:
- I noticed a few outstanding v2 SDK references that may or may not be an issue (I'm unsure). Can you let me know what you think?
- One example
- .dockerignore --> should this just be
build
instead ofv2/build
? Or maybe we can just appendbuild
to the list? - Do we want to update the imports/namespace references in the components/ directory? (Example)
- Do we want to update the v2 imports (and namespace) in the pipelines/frontend/mock-backend/data/v2/pipeline/ directory (example)?
- Can you explain why we want to keep the v2/ directory with only an empty
__init__.py
file? Is it possible to remove this? Tests pass when this is removed.
Thanks for the review!
|
/approve |
/lgtm Thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun, connor-mccarthy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* feat(sdk)!: move v2 to main namespace * edit samples
Description of your changes:
Checklist: