Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extract the pipelineparam deserialize function #841

Merged
merged 5 commits into from
Feb 25, 2019
Merged

extract the pipelineparam deserialize function #841

merged 5 commits into from
Feb 25, 2019

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Feb 20, 2019 •
edited by jlewi
Loading

Move the deserialize/matching function of the pipelineparam to the same class of PipelineParam such that future changes are much easier whenever we need to modify the pipelineparam.

This change is Reviewable

hongye-sun
hongye-sun reviewed Feb 20, 2019
View reviewed changes
Copy link
Contributor

@hongye-sun hongye-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

3 similar comments
@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

@k8s-ci-robot k8s-ci-robot removed the lgtm label Feb 21, 2019
@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

@gaoning777
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hongye-sun
Copy link
Contributor

/lgtm

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@k8s-ci-robot k8s-ci-robot merged commit 81d7a4e into kubeflow:master Feb 25, 2019
cheyang pushed a commit to alibaba/pipelines that referenced this pull request Mar 28, 2019
@gaoning777 @k8s-ci-robot
extract the pipelineparam deserialize function (kubeflow#841)
d969f82 
* extract the pipelineparam deserialize function

* typo fix

* adjust extract_param to accept a list of strings

* convert arg to string

* bug fix, add unit tests
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
Remove stale ksonnet code (kubeflow#841)
a2d2228
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
@Tomcli
Add support to parse pipeline param in json string (kubeflow#841)
ca81bf0 
* add support to parse pipeline param in json string

* update license
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hongye-sun hongye-sun hongye-sun left review comments

@elikatsis elikatsis elikatsis left review comments

@Ark-kun Ark-kun Awaiting requested review from Ark-kun

Assignees

@hongye-sun hongye-sun

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gaoning777 @k8s-ci-robot @hongye-sun @elikatsis