-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk): deprecate .set_gpu_limit in favor of .set_accelerator_limit #8836
feat(sdk): deprecate .set_gpu_limit in favor of .set_accelerator_limit #8836
Conversation
Skipping CI for Draft Pull Request. |
2070e5a
to
c20dbde
Compare
/assign @IronPan
|
c20dbde
to
7e0d217
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@connor-mccarthy: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Description of your changes:
Deprecates pipeline task
.set_gpu_limit
in favor of.set_accelerator_limit
, since limits can be set for both GPUs and TPUs.Checklist:
title convention. Learn more about the pull request title convention used in this repository.