Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): deprecate .set_gpu_limit in favor of .set_accelerator_limit #8836

Conversation

connor-mccarthy
Copy link
Member

@connor-mccarthy connor-mccarthy commented Feb 9, 2023

Description of your changes:
Deprecates pipeline task .set_gpu_limit in favor of .set_accelerator_limit, since limits can be set for both GPUs and TPUs.

Checklist:

@google-oss-prow
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@connor-mccarthy
Copy link
Member Author

/assign @IronPan

kubeflow-pipelines-sdk-execution-tests failures are unrelated to these changes.

@connor-mccarthy connor-mccarthy force-pushed the replace-gpu-limit-with-accelerator-limit branch from c20dbde to 7e0d217 Compare February 9, 2023 23:37
@IronPan
Copy link
Member

IronPan commented Feb 9, 2023

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Feb 9, 2023
@IronPan
Copy link
Member

IronPan commented Feb 9, 2023

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow
Copy link

@connor-mccarthy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipelines-sdk-execution-tests 7e0d217 link true /test kubeflow-pipelines-sdk-execution-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@connor-mccarthy connor-mccarthy merged commit e7ad073 into kubeflow:master Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants