Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Components - Keras - Train classifier: Changed the types to conform to the chosen type system #933

Merged
merged 1 commit into from
Mar 7, 2019
Merged

Components - Keras - Train classifier: Changed the types to conform to the chosen type system #933

merged 1 commit into from
Mar 7, 2019

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Mar 7, 2019 •
edited by jlewi
Loading

This change is Reviewable

@neuromage
Copy link
Contributor

/lgtm

Did we already check in the types? Thought we were still working on them?

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Mar 7, 2019 •
edited
Loading

Did we already check in the types? Thought we were still working on them?

AFAIK, Ning has already checked in couple of type-related PRs and there are some more coming.

Yesterday, when we tried to load this component on his machine, there was error during conversion to ContainerOp since the typing code could not recognize the format I've used (GcsPath: TSV vs GcsPath: {data_type: TSV}). So I decided to change the types here, so that there are no errors.

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Mar 7, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e54a8e3 into kubeflow:master Mar 7, 2019
@Ark-kun Ark-kun changed the title Keras - Train classifier: Changed the types to conform to the chosen type system Components - Keras - Train classifier: Changed the types to conform to the chosen type system Mar 8, 2019
cheyang pushed a commit to alibaba/pipelines that referenced this pull request Mar 28, 2019
@Ark-kun @k8s-ci-robot
Keras/Train classifier: Changed the types to conform to the chosen ty…
180a189 
…pe system (kubeflow#933)
@Ark-kun Ark-kun deleted the Keras/Train-classifier--Changed-the-types-to-conform-to-the-chosen-type-system branch March 29, 2019 21:46
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
@Bobgy
feat(gcp): upgrade KFP to 1.5.0-rc.0 (kubeflow#933)
f45f3a9
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@yuzisun
Publish KFServing 0.4 release (kubeflow#933)
1862ff6 
* Publish v0.4.0 release

* add license
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neuromage neuromage Awaiting requested review from neuromage

@gaoning777 gaoning777 Awaiting requested review from gaoning777

@hongye-sun hongye-sun Awaiting requested review from hongye-sun

Assignees

@neuromage neuromage

@gaoning777 gaoning777

Labels
approved area/components lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ark-kun @neuromage @k8s-ci-robot @gaoning777