Skip to content
This repository has been archived by the owner on Sep 19, 2022. It is now read-only.

Use multi-build to build pytorch-operator image #198

Merged
merged 3 commits into from
Aug 8, 2019

Conversation

hmtai
Copy link
Contributor

@hmtai hmtai commented Aug 6, 2019

Use multi-build to build pytorch-operator image.
See detail: #195

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@k8s-ci-robot
Copy link

Hi @hmtai. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Use multi-build to build pytorch-operator image.
@gaocegege
Copy link
Member

/ok-to-test

@hmtai
Copy link
Contributor Author

hmtai commented Aug 6, 2019

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@coveralls
Copy link

coveralls commented Aug 6, 2019

Coverage Status

Coverage remained the same at 85.281% when pulling cc06855 on hmtai:patch-1 into ca2c9c4 on kubeflow:master.

Dockerfile Outdated
WORKDIR /go/src/github.com/kubeflow/pytorch-operator

# Build pytorch operator v1beta2 binary
RUN go build github.com/kubeflow/pytorch-operator/cmd/pytorch-operator.v1beta2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go build cmd/pytorch-operator.v1beta2
go build cmd/pytorch-operator.v1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes,I agree with you:>

Dockerfile Outdated
# Build pytorch operator v1beta2 binary
RUN go build cmd/pytorch-operator.v1beta2
# Build pytorch operator v1 binary
RUN go build cmd/pytorch-operator.v1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RUN go build ./cmd/pytorch-operator.v1
RUN go build ./cmd/pytorch-operator.v1beta2

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we need ./ here.

@hougangliu
Copy link
Member

/lgtm
Thanks @hmtai

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gaocegege
Copy link
Member

Thanks for your contribution! 🎉 👍

Copy link
Contributor Author

@hmtai hmtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes,if ignore vendor here,during build the image in container it will failed because it can not find the dependency packages.

.gcloudignore Show resolved Hide resolved
@gaocegege
Copy link
Member

Then LGTM

@johnugeorge
Copy link
Member

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@johnugeorge
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit 9a6ae63 into kubeflow:master Aug 8, 2019
@hmtai hmtai deleted the patch-1 branch August 9, 2019 01:16
@hmtai
Copy link
Contributor Author

hmtai commented Aug 9, 2019

Thanks for your review and comments @johnugeorge @gaocegege
@hougangliu

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants