-
Notifications
You must be signed in to change notification settings - Fork 143
Use multi-build to build pytorch-operator image #198
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Hi @hmtai. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Use multi-build to build pytorch-operator image.
/ok-to-test |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Dockerfile
Outdated
WORKDIR /go/src/github.com/kubeflow/pytorch-operator | ||
|
||
# Build pytorch operator v1beta2 binary | ||
RUN go build github.com/kubeflow/pytorch-operator/cmd/pytorch-operator.v1beta2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go build cmd/pytorch-operator.v1beta2
go build cmd/pytorch-operator.v1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes,I agree with you:>
Dockerfile
Outdated
# Build pytorch operator v1beta2 binary | ||
RUN go build cmd/pytorch-operator.v1beta2 | ||
# Build pytorch operator v1 binary | ||
RUN go build cmd/pytorch-operator.v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RUN go build ./cmd/pytorch-operator.v1
RUN go build ./cmd/pytorch-operator.v1beta2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah we need ./
here.
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks for your contribution! 🎉 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes,if ignore vendor here,during build the image in container it will failed because it can not find the dependency packages.
Then LGTM |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Thanks for your review and comments @johnugeorge @gaocegege |
Use multi-build to build pytorch-operator image.
See detail: #195