Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump appVersion to v1beta2-1.5.0-3.5.0 #2044

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

ChenYi015
Copy link
Contributor

@ChenYi015 ChenYi015 commented Jun 3, 2024

🛑 Important:

Please open an issue to discuss significant work before you start. We appreciate your contributions and don't want your efforts to go to waste!

For guidelines on how to contribute, please review the CONTRIBUTING.md document.

Purpose of this PR

Provide a clear and concise description of the changes. Explain the motivation behind these changes and link to relevant issues or discussions.

Close #2034.

Proposed changes:

  • Bump chart appVersion to v1beta2-1.5.0-3.5.0.

Change Category

Indicate the type of change by marking the applicable boxes:

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Rationale

In PR #1998, the chart appVersion changed from v1beta2-1.4.6-3.5.0 to v1beta2-1.4.2-3.5.0 incorrectly. We should bump the appVersion to v1beta2-1.5.0-3.5.0 to build a new version of operator image to make the helm chart work again.

Checklist

Before submitting your PR, please review the following:

  • I have conducted a self-review of my own code.
  • I have updated documentation accordingly.
  • [] I have added tests that prove my changes are effective or that my feature works.
  • Existing unit tests pass locally with my changes.

Additional Notes

Copy link
Contributor

@yuchaoran2011 yuchaoran2011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vara-bonthu Could you have a look too?

Signed-off-by: Yi Chen <github@chenyicn.net>
@ChenYi015 ChenYi015 changed the title Revert appVersion to v1beta2-1.4.6-3.5.0 Bump appVersion to v1beta2-1.5.0-3.5.0 Jun 5, 2024
Copy link
Contributor

@yuchaoran2011 yuchaoran2011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yuchaoran2011

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 2219563 into kubeflow:master Jun 5, 2024
7 checks passed
@ChenYi015 ChenYi015 deleted the fix/version branch July 18, 2024 09:27
jacobsalway pushed a commit to jacobsalway/spark-operator that referenced this pull request Jul 25, 2024
Signed-off-by: Yi Chen <github@chenyicn.net>
sigmarkarl pushed a commit to spotinst/spark-on-k8s-operator that referenced this pull request Aug 7, 2024
Signed-off-by: Yi Chen <github@chenyicn.net>
jbhalodia-slack pushed a commit to jbhalodia-slack/spark-operator that referenced this pull request Oct 4, 2024
Signed-off-by: Yi Chen <github@chenyicn.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm chart references non-existent version v1beta2-1.4.2-3.5.0
2 participants