-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable istio sidecar injection in simple tfjob test #1148
Conversation
/assign @richardsliu |
/lgtm |
/cc @jlewi |
Looks like a flaky test. |
Tests are passing now. |
/lgtm |
@gaocegege @richardsliu /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ChanYiLin, jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thank you @ChanYiLin! |
Unblocks kubeflow/kfctl#131, because kfctl uses tf-operator head for presubmit test.
After enabling istio sidecar injection in
kubeflow
namespace, tfjob-smoke-test is the only test timing out.I haven't been able to look at pod log/info because there were permission issues, but I've found other people mentioning tfjob cannot work with istio sidecar: kubeflow/kubeflow#3935
/cc @jlewi
This change is