Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Support ARM64 platform in XGBoost examples #2114

Merged

Conversation

tico88612
Copy link
Contributor

What this PR does / why we need it:

  • Support ARM64 platform in XGBoost examples

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #2113

Checklist:

  • Docs included if any changes are user facing

@coveralls
Copy link

coveralls commented May 17, 2024

Pull Request Test Coverage Report for Build 9129580062

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 35.415%

Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob_controller.go 2 81.05%
Totals Coverage Status
Change from base Build 9122596266: -0.02%
Covered Lines: 4378
Relevant Lines: 12362

💛 - Coveralls

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution!

.github/workflows/publish-example-images.yaml Outdated Show resolved Hide resolved
Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com>
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 687f0c9 into kubeflow:master May 17, 2024
39 checks passed
@tico88612 tico88612 deleted the feat/example-xgboost-arm64 branch May 17, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ARM64 platform in XGBoost examples
3 participants