Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc.go to v1beta1 API #950

Merged
merged 1 commit into from
Mar 6, 2019
Merged

Conversation

richardsliu
Copy link
Contributor

@richardsliu richardsliu commented Mar 6, 2019

This is to enable API reference docs generation.

See #731


This change is Reviewable

@richardsliu
Copy link
Contributor Author

/assign @johnugeorge

@coveralls
Copy link

Coverage Status

Coverage remained the same at 76.744% when pulling a91cddc on richardsliu:doc_v1beta1 into 7f429a2 on kubeflow:master.

@richardsliu
Copy link
Contributor Author

/retest

@johnugeorge
Copy link
Member

/lgtm

@johnugeorge
Copy link
Member

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4e86081 into kubeflow:master Mar 6, 2019
@richardsliu richardsliu deleted the doc_v1beta1 branch May 23, 2019 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants