Fixed broken links in gke-monitoring

[janeman98]

Part of fixes for issue# 1683.

@sarahmaddox
I have changed the origin broken url:
https://github.com/kubeflow/kubeflow/blob/master/kubeflow/gcp/metric-collector.libsonnet#L83
to
https://github.com/kubeflow/kubeflow/blob/master/metric-collector/service-readiness/kubeflow-readiness.py

I am not sure whether this is correct. Can you have someone familiar with this to review? Thanks!

---

This change is 

[janeman98]

/assign @sarahmaddox

[sarahmaddox]

Thanks @janeman98!
@Bobgy Please would you take a look at the example and advise if it's correct or if there's a better example to link to?

/assign @Bobgy

[Bobgy]

Sorry, I don't have knowledge on this either.
/assign @jlewi

[jlewi]

/assign @kunmingg

This entire page is probably out of date. One solution would probably just replace the entire page contents with a message telling people to check out
https://cloud.google.com/monitoring/kubernetes-engine/prometheus

@kunmingg do we have any guidance to offer users beyond what's on that page.?

[janeman98]

Hi @kunmingg

Any update on this? If not, I will just replace the entire page contents with a message telling people to check out other page as Jeremy suggested above.

[sarahmaddox]

@janeman98 Please would you replace the entire contents of the page with a short description of Prometheus (like the one on the Cloud page) and a link to the the Cloud page.

Please would you also create a Kubeflow website issue asking whether there's any useful info we can grab from this page in the Kubeflow v0.7 docs (that is, an older version of this page). Assign the issue ro @kunmingg for investigation. :)

[sarahmaddox]

Preview: https://deploy-preview-1748--competent-brattain-de2d6d.netlify.com/docs/gke/monitoring/

[sarahmaddox]

Thanks @janeman98 This looks great. I've added a couple of comments. (It seems the GCP docs point to GitHub instead of the Prometheus website in one case. :) )

[janeman98]

Thanks @sarahmaddox for the review!

I have modified the file as what you suggested. Please review/approve. Feel free to let me know if there is anything else that need to be changed.

Also, I have created issue# 1772 and assign to kunmingg.

[sarahmaddox]

Thanks!

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sarahmaddox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sarahmaddox]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[janeman98]

Thanks @sarahmaddox !